fix(ci): treat a passed scoped run with no src coverage as legitimate, not a missing report#8195
Merged
Merged
Conversation
…, not a missing report The third scoped-selection edge case in a week (PR #8192's shards): the selection matched real tests that PASSED but exercised nothing under coverage.include (src/**) — a test-only/docs-drift diff — so --coverage.all=false wrote an empty lcov and 'Verify coverage report exists' failed a green run. no_tests_matched cannot see this case because tests DID match. The scoped branch now derives a second output (no_src_coverage) from the run itself: reachable only on vitest exit 0, detected by the absent/empty lcov, proven by the junit report the same command wrote. Every verify/upload guard carries both escapes, and the codecov-policy drift test pins the full condition strings plus both detector lines so neither can silently vanish. Scoped selection itself stays DISABLED via SCOPED_TEST_SELECTION_ENABLED=false until the re-enable decision documented on the issue. Advances #8194
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The #8194 hardening: the third scoped-selection edge case in a week (the one that redded PR #8192's shards). The scoped run matched real tests that passed but exercised nothing under
src/**, so--coverage.all=falsewrote an empty lcov and 'Verify coverage report exists' failed a green run —no_tests_matchedcan't catch it because tests did match.How
no_src_coverage, from the run itself: the detector line is only reachable on vitest exit 0 (set -o pipefail), triggered by an absent/empty lcov, with the junit report as proof the suite ran. The success signal is the test run, never the coverage file's size.codecov-policy.test.tspins the full condition strings and both detector lines, so neither escape can silently vanish — that's the regression-shape coverage ci: harden scoped test selection before re-enabling — third distinct red-CI edge case this week #8194 asks for.Notes
SCOPED_TEST_SELECTION_ENABLED=false(set tonight); this PR makes the path safe for a future re-enable decision, which stays with ci: harden scoped test selection before re-enabling — third distinct red-CI edge case this week #8194.Validation
actionlintgreen;codecov-policysuite green locally (8/8).Advances #8194